[Bug 747394] rtpsession: Track RTX ssrc caps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747394

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301541|none                        |reviewed
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 301541:
 --> (https://bugzilla.gnome.org/review?bug=747394&attachment=301541)

::: gst/rtpmanager/gstrtprtxsend.c
@@ +604,3 @@

+      /* The session might need to know the RTX ssrc */
+      caps = gst_caps_make_writable (caps);

Still wrong, you don't own the reference to caps... so would have to copy in
any case. I fixed that locally :)

::: gst/rtpmanager/rtpsession.c
@@ +2707,3 @@
+          obtain_internal_source (sess, ssrc, &created, GST_CLOCK_TIME_NONE);
+      if (source) {
+        rtp_source_update_caps (source, caps);

Problem here now is that the caps contain the ssrc and the payload type, but
those are going to be invalid for the newly created source.

Looking into this now

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.