[Bug 705991] Adding support for DASH common encryption to qtdemux and dashdemux

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=705991

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301697|none                        |reviewed
             status|                            |

--- Comment #118 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 301697
  --> https://bugzilla.gnome.org/attachment.cgi?id=301697
Creates gstprotection in GStreamer core

Looks good overall, thanks.

>+GType
>+gst_protection_meta_api_get_type (void)
>+{
>+  static volatile GType type;
>+  static const gchar *tags[] = { "memory", NULL };

Don't think "memory" is right here. Maybe we want a "protection" tag, but for
now I'd just leave tags as { NULL };

>+gst_protection_meta_init (GstMeta * meta, gpointer params, GstBuffer * buffer)
>+gst_protection_meta_free (GstMeta * meta, GstBuffer * buffer)

I think those two should be static functions and not be exposed in the header.

>+/**
>+ * gst_buffer_add_protection_meta:
>+ * @buffer: #GstBuffer holding an encrypted sample, to which protection metadata
>+ * should be added.
>+ * @info: (allow-none): a #GstStructure holding cryptographic

Should also have a (transfer full) annotation. Why is it ok for info to be
NULL, is that useful for anything?

Please also add * Since: 1.6 markers at the end of all gtk-doc chunks for new
API.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.