[Bug 705991] Adding support for DASH common encryption to qtdemux and dashdemux

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Apr 17 04:01:23 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=705991

--- Comment #120 from A Ashley <bugzilla at ashley-family.net> ---
(In reply to Tim-Philipp Müller from comment #119)
> Comment on attachment 301696 [details] [review]
> event: Create a new Protection event
> 
> Also looks good, just a few minor niggles:
> 
> 
> >   GST_EVENT_SINK_MESSAGE          = GST_EVENT_MAKE_TYPE (100, FLAG(DOWNSTREAM) | FLAG(SERIALIZED) | FLAG(STICKY) | FLAG(STICKY_MULTI)),
> >   GST_EVENT_EOS                   = GST_EVENT_MAKE_TYPE (110, FLAG(DOWNSTREAM) | FLAG(SERIALIZED) | FLAG(STICKY)),
> >   GST_EVENT_TOC                   = GST_EVENT_MAKE_TYPE (120, FLAG(DOWNSTREAM) | FLAG(SERIALIZED) | FLAG(STICKY) | FLAG(STICKY_MULTI)),
> >+  GST_EVENT_PROTECTION = GST_EVENT_MAKE_TYPE (130,
> >+      FLAG (DOWNSTREAM) | FLAG (SERIALIZED) | FLAG (STICKY) |
> >+      FLAG (STICKY_MULTI)),
> 
> Please align your addition with that of the other events.
>   

I've tried, but the gst-indent commit hook is stopping me from making a commit
with the format used by the other events.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list