[Bug 748033] gstglupload: Fix GstGLUpload leak

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Apr 17 04:29:41 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=748033

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301803|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 301803:
 --> (https://bugzilla.gnome.org/review?bug=748033&attachment=301803)

::: ext/gl/gstgluploadelement.c
@@ +99,3 @@
   bt_class->passthrough_on_same_caps = TRUE;

+  element_class->change_state = gst_gl_upload_change_state;

IMHO cleaner to do it in basetransform_class->stop :) Also less code for you to
write

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list