[Bug 747954] osx: fix libcheck and "make check" builds with clang

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747954

--- Comment #5 from Julien Isorce <julien.isorce at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #4)
> So it's fixed in newer libtool?

Nop, sorry I should have commented these infos.

(In reply to Julien Isorce from comment #3)
> Some infos:
> 
> * From https://autotools.io/libtool/lafiles.html:
> 
> "inherited_linker_flags:
> This variable lists selected link editor flags that are needed to ensure the
> correct ABI is used with the library, for instance. In most cases, all
> you'll be seeing in here is -pthread, as it's probably the only such flag
> used on modern systems."

It is confusing because I do not know any linker that support -pthread. But at
the time this sentence has been written maybe "modern" became "old" and even
"obsolete".

> 
> * In libtool's git log:
> 
> commit 2f15fc7d18de0492067f4c2c782d1c8bb624194e
> Author: Christoph Egger <Christoph_Egger at gmx.de>
> Date:   Wed Feb 23 03:30:30 2005 +0000
> 
>     * config/ltmain.m4sh (func_mode_link): Add -pthread like flags to
>     inherited_linker_flags.
> 
> --- a/config/ltmain.m4sh
> +++ b/config/ltmain.m4sh
> @@ -2686,6 +2686,10 @@ func_mode_link ()
>         compiler_flags="$compiler_flags $arg"
>         compile_command="$compile_command $arg"
>         finalize_command="$finalize_command $arg"
> +       case "$new_inherited_linker_flags " in
> +           *" $arg "*) ;;
> +           * ) new_inherited_linker_flags="$new_inherited_linker_flags
> $arg" ;;
> +       esac
>         continue
>         ;;

Here it was to mention a feature that has been add in 2005. Maybe it was for
older linkers.

> 
> Also:
> http://git.savannah.gnu.org/cgit/libtool.git/tree/build-aux/ltmain.in#n5161
> http://git.savannah.gnu.org/cgit/libtool.git/tree/build-aux/ltmain.in#n5691

Here it was to mention that this is still present 10 years after.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.