[Bug 748068] equalizer not changing settings dynamically

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748068

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net
 Attachment #301863|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Comment on attachment 301863
  --> https://bugzilla.gnome.org/attachment.cgi?id=301863
we need update_coefficients () to run for the dynamic changes in the bands'
properties

Additionally you should ideally check in transform_ip() if it is passthrough or
not with the current coefficients.

Also changing the coefficients should disable passthrough mode (unless changed
back to doing nothing).
So in theory this commit shouldn't be necessary, unless a) bug in basetransform
or b) we don't unset passthrough when properties change

-- 
You are receiving this mail because:
You are the QA Contact for the bug.