[Bug 748119] New: GstMetaTransformFunction returns gboolean but its retval is discarded

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748119

            Bug ID: 748119
           Summary: GstMetaTransformFunction returns gboolean but its
                    retval is discarded
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Mac OS
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: ilya.konstantinov at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

In gstmeta.h:

/**
 ...
 * Returns: %TRUE if the transform could be performed
 */
typedef gboolean (*GstMetaTransformFunction) (GstBuffer *transbuf,
                                              GstMeta *meta, GstBuffer *buffer,
                                              GQuark type, gpointer data);

However, in gstbuffer.c:

  if (flags & GST_BUFFER_COPY_META) {
    ...
      if (info->transform_func) {
        ...
        info->transform_func (dest, meta, src,
            _gst_meta_transform_copy, &copy_data); // <-- retval unused
      }
  }

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.