[Bug 725167] opusdec PLC doesn't seem to work as well as Chrome

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=725167

Carlos Rafael Giani <dv at pseudoterminal.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dv at pseudoterminal.org

--- Comment #20 from Carlos Rafael Giani <dv at pseudoterminal.org> ---
Created attachment 301992
  --> https://bugzilla.gnome.org/attachment.cgi?id=301992&action=edit
New patch for PLC frame size calculation

I wrote a new patch based on the idea from Vincent Penquerc'h . It does
essentially the same as his patch, with the following differences:

(1) The calculations are done with the durations instead of the sample count.
The criterion for Opus' PLC to work is that frame lengths must be a multiple of
2.5ms, so it makes sense to do the calculations directly in the time domain.

(2) The patch had a bug that caused decoding errors. Since the plc_samples
value got rounded (and not just truncated), the leftover samples count could
become negative. Furthermore, PLC intervals which are smaller than 2.5ms were
not being handled properly. The new patch fixes these issues.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.