[Bug 746209] Merge glfiltersobel, glfilterblur and glfilterlaplacian into gleffects

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=746209

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #302043|none                        |reviewed
             status|                            |

--- Comment #32 from Julien Isorce <julien.isorce at gmail.com> ---
Review of attachment 302043:
 --> (https://bugzilla.gnome.org/review?bug=746209&attachment=302043)

You forgot a remark but that's fine I'll amend the commit before pushing.

::: ext/gl/effects/gstgleffectsobel.c
@@ +156,3 @@
+    gst_gl_shader_set_uniform_1i (shader, "tex", 0);
+    gst_gl_shader_set_uniform_1f (shader, "width", width);
+    gst_gl_shader_set_uniform_1f (shader, "height", height);

These 2 lines should be removed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.