[Bug 748068] equalizer: not changing settings dynamically

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748068

Luis de Bethencourt <luis at debethencourt.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301863|reviewed                    |none
             status|                            |
 Attachment #301863|0                           |1
        is obsolete|                            |

--- Comment #5 from Luis de Bethencourt <luis at debethencourt.com> ---
Created attachment 302085
  --> https://bugzilla.gnome.org/attachment.cgi?id=302085&action=edit
equalizer: fix dynamic changes on bands

Move the passthrough check from the transform function to when the gain
properties are changed.

Currently when we are in passthrough, even after the gains change the
passthrough check never happens because it is inside the transform function
which doesn't run. This fix moves this check to the set_property() function, so
whenever the gain coefficient changes we check if they are all 0.0 and we can
passthrough.

I also set the passthrough to TRUE at init because the gains default to 0, so
we can passthrough until any gain property is changed.

Tested with both gst-launch-1.0 (properties set before rolling) and
test/examples/equalizer/demo (everything default to 0.0 and changed dynamically
while rolling).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.