[Bug 748322] wayland: GTK+ video overlay example

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748322

--- Comment #3 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Olivier Crête from comment #2)
> The code looks good. 

Thanks!

> I guess once the waylandsink API stabilizes, we'll want
> to add this to the various other examples we have instead of having a
> separate wayland one, but it's probably too early for that.

What other examples? As far as I see, there's a video overlay example in
gst-plugin-base, but focused on X. I modified it to support waylandsink, but
then I realized gl has their own video overlay example too in gst-plugin-bad,
so I decided to follow its steps, since both are in gst-plugin-bad.

IMO, would be good to push tests for waylandsink as soon as possible, so others
could dig in the plugin easily. 

> Also, you probably want to add code to deal with changes in the window size,
> as this is the annoyingly non-trivial part with wayland. I'd love to be able
> to convince team wayland to change libwayland-client to make our lives
> easier, but for now, we're stuck with a complex multi-step process.

Yes, I didn't work of that feature. Even the _set_render_rectangle() isn't
working as expected (the videotestsrc appears displaced).

> 
> Shouldn't "gtk_window_move()" just do nothing on Wayland?

It seems so.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.