[Bug 748439] New: vtdec: strange error handling

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748439

            Bug ID: 748439
           Summary: vtdec: strange error handling
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: ilya.konstantinov at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

In gst_vtdec_handle_frame:

  status =
      VTDecompressionSessionDecodeFrame (vtdec->session, cm_sample_buffer,
      input_flags, frame, NULL);
  if (status != noErr && FALSE)
    goto error;

I guess the "&& FALSE" is debug-time code that sneaked into the commit.
Introduced in:

commit b1a756fda730d5edde0d6d83df723d8923008f98
Author: Alessandro Decina <alessandro.d at gmail.com>
Date:   Sat Dec 7 23:55:13 2013 +0100

    applemedia: rewrite VideoToolbox decoder based on GstVideoDecoder

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.