[Bug 748107] tsdemux: fix build error with clang

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748107

Ilya Konstantinov <ilya.konstantinov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ilya.konstantinov at gmail.com

--- Comment #6 from Ilya Konstantinov <ilya.konstantinov at gmail.com> ---
(In reply to Tim-Philipp Müller from comment #4)
> Looks like Luis "fixed" this already by just removing it as well..

http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=f52cf2a7c4a03065eb435d9df390923783f4c715

(In reply to Yujin Lee from comment #5)
> But this patch is intended to prevent the segment position from being assigned a negative value.

In your version, it'll just be a noop. (We certainly don't mean to make the
"negative" half of the position values invalid.)

(In reply to Vincent Penquerc'h from comment #2)
> if (GST_BUFFER_PTS (buffer) > stream->first_dts)
>   demux->segment.position = GST_BUFFER_PTS (buffer) - stream->first_dts;
> else
>   demux->segment.position = 0;

Something is seriously broken if that happens (as first_dts <= dts1 <= pts1 <
dts2 <= pts2 ...).

If we believe such a scenario is likely, and want to be defensive, I wonder if
we're better logging the error and dropping the buffer, instead of silently
propagating the error in the form of a sudden position drop.

If such a scenario is unlikely, this bug can be closed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.