[Bug 748452] System registry cache file

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748452

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #302337|none                        |reviewed
             status|                            |

--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 302337
  --> https://bugzilla.gnome.org/attachment.cgi?id=302337
registry: Don't store hash of environment variables

> The intended purpose is that if the
> environment variables haven't changed,
> then scanning of the directories
> they point to can be skipped. However,
> this actually isn't the case as
> the scanning for plugin dependencies
> happens unconditionally.
>
> Drop usage of this hash as it can only
> cause additional registry
> rebuilds to occur.
> 
> If the expanded environment variables
> are different, then this will already
> cause the dependency scanning to search
> different locations.

I didn't re-read the code in detail just now, but I'm not sure if the (my)
comment in gstplugin.c why we store the environment variable hash is correct.
One purpose of the hash is to trigger rescanning of a plugin when certain
environment variables change. Example: we have a wrapper plugin around a
library that itself has plugins and the FOO_PLUGINS_PATH env variable
determines where that lib should look for additional plugins. Now if someone
sets or changes FOO_PLUGINS_PATH that might cause the foo gstreamer wrapper
plugin to expose a different set of elements, so this plugin should then be
reloaded in this case.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.