[Bug 748467] New: vtenc: fix keyframe request race condition

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748467

            Bug ID: 748467
           Summary: vtenc: fix keyframe request race condition
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Mac OS
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: ilya.konstantinov at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

It is incorrect to modify the frame properties after passing them, since
VTCompressionSessionEncodeFrame takes reference and we have no control
over when it's being used.

(For example, when asking to encode frame 17, we'd modify the props
to request keyframe, submit the frame (and props), then immediately
revert the frame props back. When frame 17's time came, the encoder
would not make it a keyframe.)

In fact, the code can be simplified. We just preallocate the frame
properties needed for keyframe requests, use use this single instance.
When keyframe is not needed, we just pass NULL.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.