[Bug 747495] gst_base_text_overlay_push_frame() doesn't make memory copy when video buffer's memory is ready only

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747495

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
 Attachment #301113|0                           |1
           is patch|                            |
 Attachment #301113|none                        |rejected
             status|                            |
 Attachment #301113|application/mbox            |text/plain
          mime type|                            |

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 301113
  --> https://bugzilla.gnome.org/attachment.cgi?id=301113
make gst_base_text_overlay_push_frame perform deep copy when memory of a buffer
is read only

This doesn't look right, and shouldn't be needed.

When gst_buffer_map() is asked to map for writing and the memory is not
writable for some reason (e.g. because it has been flagged as readonly, or is
shared between multiple buffers), a copy will be made automatically before
mapping.

/**
 * gst_buffer_map:
 *
 * @flags describe the desired access of the memory. When @flags is
 * #GST_MAP_WRITE, @buffer should be writable (as returned from
 * gst_buffer_is_writable()).
 *
 * When @buffer is writable but the memory isn't, a writable copy will
 * automatically be created and returned. The readonly copy of the
 * buffer memory will then also be replaced with this writable copy.

It sounds to me like maybe something your decoder does is not quite right?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.