[Bug 748467] vtenc: fix keyframe request race condition

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Apr 26 13:00:44 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=748467

--- Comment #5 from Ilya Konstantinov <ilya.konstantinov at gmail.com> ---
> We might want to set other things in the options at a later time that persists over multiple frames

When we do, we can change it. Until then, it's just unneeded allocs per-frame.
I switched to a non-mutable CFDictionaryRef to protect from unintentional
misuse.

If you insist, I can keep an empty 'CFMutableDictionaryRef frame_props', and do
CFDictionaryCreateMutableCopy within gst_vtenc_encode_frame. My (personal)
coding style goes against code that prepares for a future that might never
come. Such code also has the drawback of giving the reader a false impression
that something is used for more than it really is.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.


More information about the gstreamer-bugs mailing list