[Bug 748489] Improve Android versions support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748489

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #302386|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 302386:
 --> (https://bugzilla.gnome.org/review?bug=748489&attachment=302386)

The patch itself is (almost) ok though of course, just wondering what your use
case is :)

Also looking forward to seeing your other patches :)

::: cerbero/bootstrap/android.py
@@ +36,3 @@
         if not os.path.exists(os.path.join(dest, "README.TXT")):
+            ndk_tar = self.NDK_TAR % (self.config.platform, self.config.arch)
+            tar = os.path.join(dest, ndk_tar)

This part should be in a different commit

::: cerbero/enums.py
@@ +107,3 @@
+    ANDROID_ECLAIR_2_1 = 'android_eclair_2_1'  # API Level 7
+    ANDROID_FROYO = 'android_froyo'  # API Level 8
+    ANDROID_GINGERBREAD_2_3_2 = 'android_gingerbread_2_3_2'  # API Level 9

Versions before API level 9 are not going to work, we use some APIs that were
introduced with 9. So not much point in keeping 8 and before around here :)

::: config/cross-android-arm64.cbc
@@ +12,3 @@
+if target_android_distro_version:
+    m.message(_("Minimum Android platform support specified to be %s" %
target_android_distro_version))
+    target_distro_version = target_android_distro_version

You could also reuse target_distro_version here, check if it was set already
and otherwise fall back to the default. No need to add another configuration

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.