[Bug 748521] New: videodecoder: decide_allocation w/ caps = NULL

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748521

            Bug ID: 748521
           Summary: videodecoder: decide_allocation w/ caps = NULL
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: ilya.konstantinov at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

In gst_video_decoder_decide_allocation_default:

  gst_query_parse_allocation (query, &outcaps, NULL);
  gst_video_info_init (&vinfo);
  if (outcaps)
    gst_video_info_from_caps (&vinfo, outcaps);

However, outcaps == NULL is not legit to begin with, and will cause an
assertion later in:

  gst_buffer_pool_config_validate_params (config, outcaps, size, min,
            max)

I think the 'if (outcaps)' check can be discarded.

Additionally, we might want to fail fast if !outcaps -- both in
gst_video_decoder_decide_allocation_default and
gst_base_src_decide_allocation_default.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.