[Bug 748529] adaptivedemux: only update stream position if query success

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Apr 28 06:21:28 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=748529

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #302493|none                        |reviewed
             status|                            |

--- Comment #3 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 302493:
 --> (https://bugzilla.gnome.org/review?bug=748529&attachment=302493)

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +1992,2 @@
         have_pos =
             gst_pad_peer_query_position (cur_stream->pad, GST_FORMAT_TIME,

Perhaps we can eliminate the have_pos variable altogether and just put the pad
query inside the if below. It looks easier to read IMHO.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list