[Bug 738237] baseparse: parser is never marked as FLAG_LOST_SYNC on discont

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=738237

Ilya Konstantinov <ilya.konstantinov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ilya.konstantinov at gmail.com

--- Comment #3 from Ilya Konstantinov <ilya.konstantinov at gmail.com> ---
Options:
a) gst_base_parse_frame_update is static inline and only used in
gst_base_parse_prepare_frame. Perhaps bringing it inside will help clarity.

b) bring this section inside gst_base_parse_frame_update:

  if (parse->priv->discont) {
    GST_DEBUG_OBJECT (parse, "marking DISCONT");
    GST_BUFFER_FLAG_SET (buffer, GST_BUFFER_FLAG_DISCONT);
    parse->priv->discont = FALSE;
  }

c) move "parse->priv->discont = FALSE;" to the end of the function, to clarify
that clearing it is separate from handling it

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.