[Bug 747757] winks: add GstDeviceProvider implementations on Windows

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747757

--- Comment #14 from LRN <lrn1986 at gmail.com> ---
(In reply to Olivier Crête from comment #13)
> Review of attachment 302528 [details] [review]:
> 
> The GstDeviceProvider itself seems to be missing from the patch.
> 
> ::: sys/winks/gstksclock.c
> @@ -226,3 @@
>      GST_KS_CLOCK_LOCK ();
>    }
> -
> 
> Why remove all of the empty lines here and below?

Because gst-indent told me so.

> 
> ::: sys/winks/gstksvideosrc.c
> @@ -468,3 @@
>            gst_ks_video_src_alloc_buffer, self);
>      }
> -
> 
> Why remove all the the empty lines again?

Because gst-indent told me so. It wouldn't let me commit unless i removed them.

> 
> @@ +1070,3 @@
> +
> +  GST_DEBUG_CATEGORY_INIT (gst_ks_debug, "ksvideosrc",
> +      0, "Kernel streaming video source");
> 
> Do the category init before the register, in case there are debug messages
> in the class init in the future

Roger.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.