[Bug 748627] rtpsession: Don't send NACKs and early RTCP in non-feedback profiles

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748627

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|rtpsession: First RTCP      |rtpsession: Don't send
                   |packet is delayed too much  |NACKs and early RTCP in
                   |(regression)                |non-feedback profiles

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
I think it all does the right thing actually. Whenever we send early feedback,
the next regular RTCP packet is delayed accordingly so that we still on average
send one RTCP packet every ~5 seconds (rtcp-min-interval + jitter). So for
session 0 we send a packet at 1s, 3s (early), 13s. Similar for session 1.

The keepalive via RTCP by this server is not defined by the spec, and it also
does not tell us in the SDP or anywhere how often we should send RTCP. So what
we're doing here is completely valid, and before the commit it was actually
wrong (we sent too much RTCP according to our settings).



But sending early RTCP here, and NACKs, is also wrong. We shouldn't do that in
non-feedback profiles. That way we would keep the gaps between RTCP packets a
bit more regular

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.