[Bug 748643] gstpad: Add a new GST_PROBE_HANDLED return value for probes

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Apr 29 08:23:24 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=748643

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
The reason it returns FALSE for queries is that unlike with buffers and events
the caller will continue to read out results from the query if it got a TRUE
return value. Now of course the default content of the queries are always
'valid' in some sense, but pretty much all callers expect sensible query
contents when they get a TRUE return value, so that's not really something we
can change in my opinion. Also, take for example the SEEKING query, seekable is
TRUE/FALSE and the query return indicates 'no response', in which case
implementations may fall back to a DURATION query instead, for example.

The alternative to adding a new return value is to add a GstFlowReturn+gboolean
ret_value member to the GstPadProbeInfo struct, which might be useful in
general in any case to spoof flow return values, but a new return value seems
more elegant to me for this particular problem.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list