[Bug 748643] gstpad: Add a new GST_PROBE_HANDLED return value for probes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748643

--- Comment #7 from Edward Hervey <bilboed at bilboed.com> ---
(In reply to Olivier Crête from comment #6)
> Adding a new return value can't be use with GST_PAD_PROBE_PASS or REMOVE,
> while a new field can.

What do you mean by that ? In all cases, we can't add a new return value (would
break API of probes), so we would need to go via the new field if we wanted to
provide more flexibility.

Also, what would the type of that field be for queries/events (where the
"return" value of pushing is a boolean) ? GST_FLOW_OK => TRUE, anything else =>
FALSE ?

Also note that adding a new field increases quite a bit the modifications to be
done in order to stay backwards-compatible with the current behaviour.
Depending on where it's called from, for what kind of data
(idle/buffer/query/event), and for what GstProbeReturn value. Tricky imho

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.