[Bug 748700] avimux: stopping file without index fails

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748700

Jesper Larsen <knorr.jesper at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #302641|0                           |1
        is obsolete|                            |

--- Comment #2 from Jesper Larsen <knorr.jesper at gmail.com> ---
Created attachment 302648
  --> https://bugzilla.gnome.org/attachment.cgi?id=302648&action=edit
avimux: Do not write index and header if idx is NULL

Actually, there are some other bugs in the rewriting of the header if using
audio, so it might indeed be best to skip the rewriting of the header.

The other bug I found is a FPE because of:
avipad->parent.hdr.rate = avipad->auds.av_bps / avipad->auds.blockalign;

#0  gst_avi_mux_audsink_set_fields (avimux=0xfe5130, avipad=0xfc9000) at
gstavimux.c:731
#1  gst_avi_mux_stop_file (avimux=avimux at entry=0xfe5130) at gstavimux.c:1827
#2  0x00007f42af2b7a28 in gst_avi_mux_do_one_buffer (avimux=0xfe5130) at
gstavimux.c:2190
#3  gst_avi_mux_collect_pads (pads=<optimized out>, avimux=0xfe5130) at
gstavimux.c:2207
#4  0x00007f42b7f76af6 in gst_collect_pads_check_collected
(pads=pads at entry=0xfe60d0) at gstcollectpads.c:1323
#5  0x00007f42b7f796f9 in gst_collect_pads_event_default
(pads=pads at entry=0xfe60d0, data=data at entry=0xfea310,
event=event at entry=0x7f4268001c90, discard=discard at entry=0) at
gstcollectpads.c:1767
#6  0x00007f42af2b80a4 in gst_avi_mux_handle_event (pads=0xfe60d0,
data=0xfea310, event=0x7f4268001c90, user_data=0xfe5130) at gstavimux.c:1926
#7  0x00007f42b7f763ea in gst_collect_pads_event (pad=pad at entry=0xfd2950,
parent=parent at entry=0xfe5130, event=event at entry=0x7f4268001c90) at
gstcollectpads.c:1989
#8  0x00007f42b8d6653a in gst_pad_send_event_unchecked (pad=pad at entry=0xfd2950,
event=event at entry=0x7f4268001c90, type=<optimized out>) at gstpad.c:5358
#9  0x00007f42b8d704f7 in gst_pad_send_event (pad=pad at entry=0xfd2950,
event=0x7f4268001c90) at gstpad.c:5525

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.