[Bug 748738] gstevent: add new api for parse seek event

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748738

--- Comment #14 from Jimmy Ohn <yongjin.ohn at lge.com> ---
(In reply to Tim-Philipp Müller from comment #12)
> I don't know, it's not clear to me that we should add 
> 
> +        GstSeekType start_type;
> +        GstSeekType stop_type;
> 
> fields to the GstSegment structure, they don't have anything to do with the
> segment, do they? We're just (ab)using the GstSegment struct here for some
> convenience function, no?
> 
> Not sure this function is really needed at all.
> 
> Maybe gst_segment_do_seek_from_event() would be sufficient too?

Tim sir.
First of all, My english skill is not good. please understand it.
I agree your opinion above comment. Actually, seektype don't have anything to
do in GstSegment structure currently. But If we add seektype to GstSegment
structure, we can "reuse" this structure simply without additional declaration
of variable related seek event such as rate, format, start, stop, seektype and
so on. 
As you know, size of segment is also same after changing structure because of
make that struct a union with the _gst_reserved field.
Also, we can change the gst_segment_do_seek fucntion simply like below.
before
-> gst_segment_do_seek(GstSegment * segment, gdouble rate, GstFormat
foramt....)
after
-> gst_segment_do_seek(GstSegment * segment, GstSegment *seek_segment)
We can reuse segment structure for segment_do_seek function also.
IMHO, If we change the segment structure, it may help gstreamer user or
developer to get simply implementation for seek event. Also I remember that
sebastian agree this changing structure before uploading this patches. Please
consider this patches for parse_seek I hope.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.