[Bug 753011] queue2: can not update upstream_size with valid data

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753011

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308377|none                        |reviewed
             status|                            |

--- Comment #7 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 308377:
 --> (https://bugzilla.gnome.org/review?bug=753011&attachment=308377)

The file mode was mistakenly updated in this patch.

::: plugins/elements/gstqueue2.c
@@ +3178,3 @@
     GST_INFO_OBJECT (queue, "upstream size: %" G_GINT64_FORMAT,
upstream_size);
+    if (upstream_size >= 0)
+      queue->upstream_size = upstream_size;

How about adding an else here to catch if it is < 0 and in this case reset the
upstream_size back to 0?

I can't think of any real life use case where that might happen but seems safer
than keeping upstream_size with an obsolete value.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.