[Bug 747965] rtppayload: payload type could be inconsistent in some payloader, which have pre-defined pt by RFC standard

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747965

--- Comment #3 from Hyunjun <zzoon.ko at samsung.com> ---
(In reply to Thiago Sousa Santos from comment #2)

> ::: gst/rtp/gstrtpg722pay.c
> @@ +139,3 @@
>    clock_rate = 8000;
>  
> +  gst_rtp_base_payload_set_options (basepayload, "audio", FALSE, "G722",
> 
> Shouldn't this be conditional if the pt being used is dynamic?

As I told you through IRC, I guess dynamic type needs to be added src caps.
And then, it should be conditional.

> 
> ::: gst/rtp/gstrtpgsmpay.c
> @@ +110,3 @@
>  
> +  if (!gst_structure_get_int (structure, "payload", &pt))
> +    pt = GST_RTP_PAYLOAD_GSM;
> 
> This is the sink caps, can we have a "payload" here? Seems unusual.

Agree. 
The existed logic to get payload type in setcaps function needs to be removed?
(eg. g723pay, g729pay)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.