[Bug 738687] midi: add alsamidisrc, an ALSA MIDI sequencer source

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Aug 7 06:37:15 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=738687

Antonio Ospite <ao2 at ao2.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #304902|reviewed                    |none
             status|                            |
 Attachment #304902|0                           |1
        is obsolete|                            |

--- Comment #5 from Antonio Ospite <ao2 at ao2.it> ---
Created attachment 308898
  --> https://bugzilla.gnome.org/attachment.cgi?id=308898&action=edit
midi: add an ALSA MIDI sequencer source v3 rebased on master

Hi, here is a v3 of the patch.

The changes since v2 are:
  - Use g_try_new() instead of g_malloc() when allocating ports
  - Use g_try_malloc() in other places to actually use the current cleanup
paths
  - Add a comment explaining how/why the file descriptors are polled
  - Improve wording and formatting for some comments
  - Rebase against the master branch (only gst/midi/Makefile.am needed some
adjustments)
  - Update author date and add a more verbose commit message

The incremental changes can be found here for a more convenient re-review:
http://ao2.it/tmp/alsamidisrc_v3_incremental/

I hope this can still make it into 1.6.

Thanks a lot,
   Antonio

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list