[Bug 752413] dashdemux: add support for parsing UTCTiming elements

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752413

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 308087:
 --> (https://bugzilla.gnome.org/review?bug=752413&attachment=308087)

Seems generally good overall, just having yet another thread is not so nice :)

::: ext/dash/gstmpdparser.c
@@ +215,3 @@
+};
+
+static struct GstMpdParserUtcTimingMethod gst_mpdparser_utc_timing_methods[] =
{

Might want to add a const here

@@ +223,3 @@
+  {"urn:mpeg:dash:utc:http-ntp:2014", GST_MPD_UTCTIMING_TYPE_HTTP_NTP},
+  {"urn:mpeg:dash:utc:direct:2014", GST_MPD_UTCTIMING_TYPE_DIRECT},
+#ifdef SUPPORT_DRAFT_2012_NAMES

Why put an #ifdef here? It shouldn't hurt to always have it there

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.