[Bug 752842] gloverlaycompositor: Wrong color format

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752842

--- Comment #6 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
(In reply to Matthew Waters from comment #5)
> So the problem with this is that GL transfers are in host endianness already
> for GL_UNSIGNED_BYTE conversion which is currently used everywhere so the
> endianness is not an issue for the texture transfers.

I'm still in doubt, but if you could provide more detail of your thinking I
could confirm. Unlike all the other case, the reason we have this byte order
check is not because of GL, as you just confirmed, we read per byte which will
indeed not affect the shader for the same format.

Though, gst_video_overlay_rectangle_get_pixels_unscaled_argb() will return
GST_VIDEO_FORMAT_BGRA when the host is little endian, and GST_VIDEO_FORMAT_ARGB
when it's big endian. These are two different formats that requires two
different shaders.

Are you still completely sure that I made a mistake ? And if so, can you
provide technical details ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.