[Bug 752413] dashdemux: add support for parsing UTCTiming elements

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752413

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309003|none                        |reviewed
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 309003:
 --> (https://bugzilla.gnome.org/review?bug=752413&attachment=309003)

::: ext/dash/gstdashdemux.c
@@ +1228,3 @@
   GstDashDemux *dashdemux = GST_DASH_DEMUX_CAST (demux);
+  return MIN (dashdemux->client->mpd_node->minimumUpdatePeriod * 1000,
+      CLOCK_UPDATE_INTERVAL);

Hm but this means that we will also update the manifest each time, right? Which
might mean that we update the manifest too often, and a server might complain
about that

::: ext/dash/gstmpdparser.c
@@ +222,3 @@
+  {"urn:mpeg:dash:utc:http-iso:2014", GST_MPD_UTCTIMING_TYPE_HTTP_ISO},
+  {"urn:mpeg:dash:utc:http-ntp:2014", GST_MPD_UTCTIMING_TYPE_HTTP_NTP},
+  {"urn:mpeg:dash:utc:direct:2014", GST_MPD_UTCTIMING_TYPE_DIRECT},

Who thought that it's a good idea to add that many methods for the same thing?
:) Not your fault of course but it's a bit... special

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.