[Bug 733235] decodebin:Handle the multi-queue size flexible
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Mon Aug 10 23:33:11 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=733235
--- Comment #27 from Myoungsun Lee <ohmygod0327 at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #25)
> ::: gst/playback/gstdecodebin2.c
> @@ +3373,3 @@
> + "'playing' buffering mode", group);
> + group->overrun = TRUE;
> + dbin->extra_buffer_required = FALSE;
>
> This doesn't seem 100% correct. Consider the case where you set
> extra_buffer_required=TRUE before. It will then buffer a bit more again. And
> then at some point might overrun again. You would then set the limits to
> small again, without the extra buffer space, making things even worse.
This patch supported only multi-queue size of pre-roll state.
It is fixed the problem which the pipeline is stopped in pre-roll state.
I think the code of your review is about PLAYING buffer size, right?
If the overrun is occurred in PLAYING state, then decodebin does nothing
originally.
So I think that it is not necessary the extra buffer in PLAYING state.
Also I uploaded new patch.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list