[Bug 753484] qtdemux: support edit lists partially in push-mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753484

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309031|none                        |reviewed
             status|                            |

--- Comment #5 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 309031:
 --> (https://bugzilla.gnome.org/review?bug=753484&attachment=309031)

::: gst/isomp4/qtdemux.c
@@ +5756,3 @@
+                  /* Only support empty segment at the beginning followed by
+                   * one non-empty segment */
+                  g_assert (i + 1 == stream->n_segments);

As it's something we don't want to support, we should maybe cleanly error out.
Assertion are better for catching programming error, not for stream errors (or
maybe this is only reached if there is a programming error elsewhere ?).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.