[Bug 753562] v4l2src: Implemented timecode metadata

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753562

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309151|none                        |needs-work
             status|                            |

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 309151:
 --> (https://bugzilla.gnome.org/review?bug=753562&attachment=309151)

That's a big patch, with a short description. It should be clear in the patch
that you want to add a new public API, and describe need and use of this public
API. This is a major change being here as you are asking us to commit to this
new API as stable.

What I don't like with the approach in this patch is that it assumes that it's
fine to consider adding a meta exclusively for one 64 bits timecode.

What about the sequence number ?
Is there possibly other meta's that are not reachable / accessible ?
What does this time code mean, how is it used ?
Is this timecode supposed to correlate with some existing GStreamer mechanism
(stream position maybe ?) ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.