[Bug 733235] decodebin:Handle the multi-queue size flexible

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=733235

--- Comment #31 from Myoungsun Lee <ohmygod0327 at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #28)
> No, my comment was about the case where you are *not* in PLAYING yet. You
> overrun, set extra buffers, now the multiqueue is not overrun anymore, at
> some point it might overrun again before going to PLAYING and you would then
> go into that if-branch. There you would set less buffering again, making the
> second overrun even worse.

I got it :). I'll think about it, and share some solutions or another logic.
Thank you.

--------------
(In reply to Justin J. Kim from comment #30)
> Review of attachment 309046 [details] [review]:
> 
> ::: gst/playback/gstdecodebin2.c
> @@ +3395,3 @@
> +    decodebin_set_queue_size (group->dbin, group->multiqueue, FALSE,
> +        (group->parent ? group->parent->seekable : TRUE));
> +  }
> 
> Is there any specific reason this statement here (out of EXPOSE_LOCK)?
> For thread-safety, it would be better to be done before calling
> EXPOSE_UNLOCK.
There is no reason. Maybe I missed that point, I will fix it. Thank you.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.