[Bug 733235] decodebin:Handle the multi-queue size flexible

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=733235

--- Comment #33 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Myoungsun Lee from comment #31)

> (In reply to Justin J. Kim from comment #30)
> > Review of attachment 309046 [details] [review] [review]:
> > 
> > ::: gst/playback/gstdecodebin2.c
> > @@ +3395,3 @@
> > +    decodebin_set_queue_size (group->dbin, group->multiqueue, FALSE,
> > +        (group->parent ? group->parent->seekable : TRUE));
> > +  }
> > 
> > Is there any specific reason this statement here (out of EXPOSE_LOCK)?
> > For thread-safety, it would be better to be done before calling
> > EXPOSE_UNLOCK.
> There is no reason. Maybe I missed that point, I will fix it. Thank you.

Reason might be that setting properties emits signals (the notify::* signals),
someone might catch them and call back into decodebin code... then causing a
deadlock. Just a guess, it might also be correct to just move it inside the
lock :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.