[Bug 752413] dashdemux: add support for parsing UTCTiming elements

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752413

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309159|none                        |needs-work
             status|                            |

--- Comment #19 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 309159:
 --> (https://bugzilla.gnome.org/review?bug=752413&attachment=309159)

I think overall this looks good to go, just some minor things. Thiago?

::: ext/dash/Makefile.am
@@ +28,3 @@
     $(GST_BASE_LIBS) \
     $(GST_LIBS) \
+    -lgstnet-$(GST_API_VERSION) \

I think this has to be $(GST_NET_LIBS)

::: ext/dash/gstdashdemux.c
@@ +194,3 @@
+#define FAST_CLOCK_UPDATE_INTERVAL  (1000000 * 30)      /* 30 seconds */
+#define SUPPORTED_CLOCK_FORMATS (GST_MPD_UTCTIMING_TYPE_NTP |
GST_MPD_UTCTIMING_TYPE_HTTP_XSDATE | GST_MPD_UTCTIMING_TYPE_HTTP_ISO |
GST_MPD_UTCTIMING_TYPE_HTTP_NTP)
+#define NTP_TO_UNIX_EPOCH 2208988800LL  /* difference (in seconds) between NTP
epoch and Unix epoch */

G_GUINT64_CONSTANT(), LL is unfortunately not portable

@@ +1577,3 @@
+        urls[clock_drift->selected_url]);
+    inet_addrs = g_resolver_lookup_by_name (resolver,
+        urls[clock_drift->selected_url], NULL, &err);

How does the NTP stuff work? I see that there's an http:// URL in the manifest,
and behind that there's some non-ASCII data. E.g.
http://dash-live-streams.appspot.com/time/ntp

Isn't that directly the NTP timestamp? Also if the manifest specifies an IP
string instead of a hostname, I think GResolver doesn't do that right thing.
IIRC code usually first tries to create a GInetAddress from the string, and
only if that fails goes through GResolver

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.