[Bug 753340] validate: media-check: fix err variable leak in media descriptor writer and parser

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753340

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
 Attachment #308874|none                        |needs-work
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 308874
  --> https://bugzilla.gnome.org/attachment.cgi?id=308874
fix memory leak

Thanks for the patch.

This doesn't look like the right GError use pattern to me.

If code is not interested in the GError, it should just pass NULL instead of a
GError address (if the API in question doesn't accept NULL for the GError
address, that should be fixed).

Next, the GError should probably be freed in the code path where the failure
occured (we can/should assume that the GError is set in that case).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.