[Bug 753490] audioecho: reallocate buffer on changing max_delay
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Aug 13 06:32:27 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=753490
Tim-Philipp Müller <t.i.m at zen.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |t.i.m at zen.co.uk
Attachment #309040|none |needs-work
status| |
--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 309040
--> https://bugzilla.gnome.org/attachment.cgi?id=309040
audioecho: buffer reallocated on changing max_delay property
Thanks, makes sense.
Minor style issue: I think you should just free the buffer unconditionally here
so that it always gets re-allocated with the new size.
The value of max_delay might also change in PROP_DELAY, so I think we should
probably free the buffer there as well.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list