[Bug 745880] sdp: SDP <-> GstCaps helper functions

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Aug 14 01:36:06 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=745880

--- Comment #17 from Hyunjun <zzoon.ko at samsung.com> ---
> +      gst_sdp_message_attributes_to_caps ((const GstSDPMessage *) sdp,
> caps);
> 
> Why the cast?
>
I'm going to remove the unnecessary cast :)


> +  base64 = (gchar *) gst_sdp_make_keymgmt (caps, ssrc);
> 
> Isn't this way of keymgmt specific to mikey? Maybe the API should be named
> like that then
Yes. 

IMHO, 2 new apis in gst-mikey could be implemented like below.
GstMIKEYMessage* gst_mikey_message_from_caps (GstCaps *)
const gchar* gst_mikey_message_base64_encode (GstMIKEYMessage*)

What do you think?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list