[Bug 703111] New plugin with convenience RTP source/sink elements

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=703111

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #267851|none                        |needs-work
             status|                            |

--- Comment #21 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 267851:
 --> (https://bugzilla.gnome.org/review?bug=703111&attachment=267851)

Might make sense to rename the gstbarco* files to something without barco :)

::: gst/barcortp/gstrtpsrc.c
@@ +479,3 @@
+        "sampling", G_TYPE_STRING, "RGB",
+        "depth", G_TYPE_INT, 24,
+        "width", G_TYPE_INT, 800, "height", G_TYPE_INT, 600, NULL);

This function does not make any sense at all :) The parameters for the
application/x-rtp caps should be retrieved from the URI, not magic values
hardcoded (why should RAW-RGB24 always be 800x600?)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.