[Bug 751147] appsink: pull_preroll returns wrong segment in the sample

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751147

George Kiagiadakis <george.kiagiadakis at collabora.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.5.3

--- Comment #9 from George Kiagiadakis <george.kiagiadakis at collabora.com> ---
commit 897371ac4fb75e5d334702341dc641a0e96f26a2
Author: George Kiagiadakis <george.kiagiadakis at collabora.com>
Date:   Fri Aug 14 18:43:03 2015 +0200

    appsink: unref the preroll buffer and cleanup the segments on stop()

    Just for consistency. No need to keep data around.

commit c3e4d8ca6fe118869506065e46fee5fe6d5bcacc
Author: George Kiagiadakis <george.kiagiadakis at collabora.com>
Date:   Fri Aug 14 18:35:22 2015 +0200

    appsink: do not update preroll_caps unless the sink is prerolling

    Just for consistency with the preroll_segment

commit 41cb26b0e9969d2b49c26a259bb3bb8a6e9217d6
Author: George Kiagiadakis <george.kiagiadakis at collabora.com>
Date:   Fri Aug 14 18:06:03 2015 +0200

    tests/appsink: add test to ensure that the segment returned by
pull-preroll/sample is correct

    https://bugzilla.gnome.org/show_bug.cgi?id=751147

commit c411819452524c281b58b531829aa3914de53ef2
Author: George Kiagiadakis <george.kiagiadakis at collabora.com>
Date:   Thu Jun 18 12:30:24 2015 +0200

    appsink: put the correct segment in the preroll sample

    last_segment is only being updated in dequeue_buffer(),
    which is only called from _pull_sample(). _pull_preroll()
    simply re-uses an old or dummy segment while the actual
    one sits and waits in the queue.

    https://bugzilla.gnome.org/show_bug.cgi?id=751147

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.