[Bug 753484] qtdemux: support edit lists partially in push-mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753484

--- Comment #6 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #5)
> Review of attachment 309031 [details] [review]:
> 
> ::: gst/isomp4/qtdemux.c
> @@ +5756,3 @@
> +                  /* Only support empty segment at the beginning followed by
> +                   * one non-empty segment */
> +                  g_assert (i + 1 == stream->n_segments);
> 
> As it's something we don't want to support, we should maybe cleanly error
> out. Assertion are better for catching programming error, not for stream
> errors (or maybe this is only reached if there is a programming error
> elsewhere ?).

It is an assert because otherwise qtdemux should ignore the edts and just play
the whole media as if it had no edts at all (the current behavior for
push-mode).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.