[Bug 753670] directsoundsink: allow specifying audio playback device

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753670

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309344|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 309344:
 --> (https://bugzilla.gnome.org/review?bug=753670&attachment=309344)

Looks good, just a small style related comment

::: sys/directsound/gstdirectsoundsink.c
@@ +413,3 @@
+    return NULL;
+
+  out = g_malloc (sizeof (GUID));

You could also use g_new(GUID, 1)

@@ +442,3 @@
             DXGetErrorString9 (hRes)), (NULL));
+    if (lpGuid)
+      g_free (lpGuid);

g_free() is NULL-safe, you can call it with NULL. Also in other places

@@ +943,3 @@
+    g_free (dsoundsink->device_id);
+  }
+  dsoundsink->device_id = g_strdup (device_id);

g_strdup0(). device_id might be NULL

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.