[Bug 753701] discoverer: Few trivial fixes in handling error cases

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753701

--- Comment #5 from Vineeth <vineeth.tm at samsung.com> ---
(In reply to Sebastian Dröge (slomo) from comment #3)
> Review of attachment 309386 [details] [review]:
> 
> ::: tools/gst-discoverer.c
> @@ +492,3 @@
>      info = gst_discoverer_discover_uri (dc, uri, &err);
> +    if (info) {
> +      print_info (info, err);
> 
> This doesn't seem like the correct fix. If there was an error, you might not
> get a info but err might contain useful information. print_info() should
> probably just print the error if info==NULL

Actually in the function gst_discoverer_discover_uri, when NULL is being
returned, error is not getting filled...
Only when current info is present, then the actual discovery starts and if it
fails then error will be allocated...
So when info is NULL err will never be allocated or filled..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.