[Bug 747774] dashdemux: text streams support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747774

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308221|none                        |reviewed
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 308221:
 --> (https://bugzilla.gnome.org/review?bug=747774&attachment=308221)

Looks generally good. But this wouldn't handle timed text without ISOBMFF
encapsulation too?

::: ext/dash/gstdashdemux.c
@@ +732,3 @@
       break;
+    case GST_STREAM_APPLICATION:
+      if (gst_mpd_client_active_stream_contains_subtitles (stream)) {

Can there be a stream that contains subtitles *and* audio/video media?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.