[Bug 733235] decodebin:Handle the multi-queue size flexible

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=733235

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309046|none                        |reviewed
             status|                            |

--- Comment #38 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 309046:
 --> (https://bugzilla.gnome.org/review?bug=733235&attachment=309046)

::: gst/playback/gstdecodebin2.c
@@ +3370,3 @@
+    dbin->extra_buffer_required = FALSE;
+    decodebin_set_queue_size (group->dbin, group->multiqueue, FALSE,
+        (group->parent ? group->parent->seekable : TRUE));

I meant the CHAIN_LOCK here btw, not the EXPOSE_LOCK

@@ +3395,3 @@
+    decodebin_set_queue_size (group->dbin, group->multiqueue, FALSE,
+        (group->parent ? group->parent->seekable : TRUE));
+  }

EXPOSE_LOCK seems unrelated to the queue size, CHAIN_LOCK seems to be needed
though

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.