[Bug 753701] discoverer: Few trivial fixes in handling error cases

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Aug 18 03:39:36 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=753701

--- Comment #10 from Vineeth <vineeth.tm at samsung.com> ---
(In reply to Sebastian Dröge (slomo) from comment #9)
> Review of attachment 309434 [details] [review]:
> 
> ::: tools/gst-discoverer.c
> @@ +383,3 @@
>  {
> +  if (info) {
> +    GstDiscovererResult result = gst_discoverer_info_get_result (info);
> 
> Instead of moving all the code around, just do
> 
> if (!info) {
>   ...
>   return;
> }
> 
> // old code

Yes i thought of this..
But for this i will have to move result and sinfo before that and later on get
the result from info_get_result

But yeah lesser changes in lines than moving the whole thing around :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list